Open
Conversation
https://github.com/reactjs/react-lifecycles-compat/blob/master/index.js#L53 在目前的版本,编译之后`isReactComponent`并不能在`Component.prototype`中找到,到时使用到react-lifecycles-compat的组件都无法在nerv正常运行。
Contributor
|
有两个问题:
|
修改函数格式以符合ts规范
Author
|
@yuche 修改 上面的明显不能通过 如果找不到 |
Contributor
|
在 这样可以应对有些库判断 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/reactjs/react-lifecycles-compat/blob/master/index.js#L53
在目前的版本,编译之后
isReactComponent并不能在Component.prototype中找到,到时使用到react-lifecycles-compat的组件都无法在nerv正常运行。