Add retry with exponential backoff to thrift server socket binding#693
Merged
Conversation
Thrift server startup intermittently fails (~5%) on fresh container startup with TTransportException when binding to the configured port. This is likely caused by a race with container networking or port TIME_WAIT from IP reuse. Wrap TServerSocket creation in a Guava Retryer (5 attempts, exponential backoff capped at 30s) to handle transient bind failures gracefully. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
04f6ea0 to
dda6b1a
Compare
gtrettenero
approved these changes
Apr 7, 2026
gtrettenero
left a comment
Contributor
There was a problem hiding this comment.
LGTM, if we still see some issues even with the retryer we might want to dive into the race condition you mentioned to avoid the transient error in the first place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thrift server startup intermittently fails (~5%) on fresh container startup with TTransportException when binding to the configured port. This is likely caused by a race with container networking or port TIME_WAIT from IP reuse.
Wrap TServerSocket creation in a Guava Retryer (5 attempts, exponential backoff capped at 30s) to handle transient bind failures gracefully.