fix: function idx#21
Open
varex83 wants to merge 2 commits into
Open
Conversation
PearsonWhite
approved these changes
Sep 17, 2024
xrvdg
reviewed
Sep 18, 2024
Comment on lines
+652
to
+654
| let lookup_fid: HashMap<usize, &FunctionId> = HashMap::from_iter( | ||
| sierra_program.funcs.iter().enumerate().map(|(idx, func)| (idx, &func.id)), | ||
| ); |
There was a problem hiding this comment.
This shouldn't be a HashMap anymore as it's just an index into a vector. Removing the HashMap and using just sierra_program will improve the constructor of NativeContractEntryPoint as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the proper function id in the lookup mapping, since
function_idxit's just the order of function in the sierra program and function.id.id isu64used to be based on an hash (of size 64) of the name of the function - so that was the original cause there. So to be more convenient it's better to use direct order of function instead of converting types