Extended create_table.pl with database type (options: mysql, MariaDB) #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The word "type" is overloaded. If the variable was named engine or server or flavor, I'd prefer that. I'd even accept a PR that sheds the separate DB vars and uses a SQL URI instead. |
Contributor
Author
|
I can change the name - no problem. "DB_ENGINE" is OK ? |
Collaborator
|
Yes |
msimerson
approved these changes
Jul 12, 2021
Merged
msimerson
added a commit
that referenced
this pull request
Oct 3, 2025
* New Features
* allow A records in in-addr.arpa #230
* import
* tinydns type 'S' records #246
* bind: add CAA imports #225
* client: add SSHFP algos 4 & 6 #303
* export/BIND: add sort order #270
* Fixes
* bump DB version to 2.35 on new install (was 2.27)
* sql
* add quotes to rank (now a MySQL keyword)
* don't save empty strings for INTs #268
* zone.last_publish: TIMESTAMP DEFAULT 0 -> DATETIME DEFAULT NULL #249
* SRV: always octal_escape numbers correctly #302
* CAA: remove any quotes added to domain name #302
* update MANIFEST path #302
* NAPTR: do not export/encode quotes #302
* NAPTR: tinydns export fix #297
* URI: tinydns export needs target escaped #296
* export: store last ts separate #247
* client: fix user password change #241
* Updates & Changes
* client: add help for CAA records #219
* client: require NAPTR replacement #221
* client: only send cookie when secure #181
* zr/sanity: don't allow spaces in names #238
* import/bind: strip trailing dot from zone #248
* import/bind: report reason on rejected records #178
* import/tinydns:
* append trailing . to SOA mname and rname if missing #166
* anchor record type detection for case lowering #165
* add imports for type 3 & 6 (IPv6 patch) #167
* handle ascii and binary in AAAA rdata #163
* improved TXT & SPF imports #171
* disable SPF records by default (flip DB flag to enable) #168
* expand UTF support to cover all UTF8 characters (requires MySQL 5.5+)
* change table encoding from utf8 (3 bits) to utf8mb4 (4 bits) #170
* Export/BIND: export CAA correctly #193
* Export/BIND/dyn: fixes for ZR updates #199, #306
* Export/Dyn: more robust handling of zone deletions, that could
result in a new zone with the same name getting unpublished.
* Exports: split long SPF records into 255 byte strings #173
* Exports: run postflight after no-change export
* session: prune pass_salt from result hash
* session: omit sessions from deleted groups
* test: delete tests already migrated to nt3
* zone2nic: match domain w/o case #254
* improved sql/create_tables.pl #190
* docker: container updates #300, #269, #267, #266, #265, #264, #263, #262, #260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the create_tables.pl script. ! non-braking change !
The changes in this pull request prepare the base for upgrading the Dockerfile from Debian 8.8 + mysql 5.5 to Debian 10 + Mariadb. The change is a NON-braking change.
The changes allow the database type (mysql or Mariadb) to be defined either via command line argument or environment variable. As used in the Dockerfile, the environment variable introduced is set in the nt_vars file with a default of "mysql". This should ensure a default which keeps everything running.
I hope this change can be accepted as a first step to upgrade the Dockerfile.
Checklist: