fixed bug in _create_fk_sql causing migrations to fail #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using Django 2.0.4. Looks like _create_index_name() changed at some point to take the table name instead of the model instance as the first argument. |
|
Thanks for the PR. I have a few django projects that need to be upgraded, so this is great. @jkapelner I did make a PR against django : django/django#8661 . I should note that the code in that PR is a bit different with the checks framework etc. That PR has been open for so long I'm less than hopeful of it ever being merged, but we shall see... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. great job on this package - definitely useful. Hopefully this gets merged into core. I found this issue when running migrations so here's the fix