hydra-eval-jobset: allow attributes other than checks/hydraJobs #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 13, 2025
| "or flake.checks " . | ||
| "or (throw \"flake '$flakeRef' does not provide any Hydra jobs or checks\")"; | ||
| my $nix_expr; | ||
| my ($ref, $attr) = split '#', $flakeRef, 2; |
There was a problem hiding this comment.
Would be great to switch this over to --select: nix-community/nix-eval-jobs@5738c86
otherwise it's impure eval.
There was a problem hiding this comment.
of course we already had this issue before hand.
There was a problem hiding this comment.
Okay, for now I can cherry pick this and I can look at --select after this repo is updated to 2.31.
There was a problem hiding this comment.
I'll try to get the ci fixed for 2.31 asap.
There was a problem hiding this comment.
I don't mind carrying the patch for a while so don't rush the work on 2.31 unless you've got other reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to build different attrs from the same flake.