Refactor galaxy redshift limit functions#222
Merged
Merged
Conversation
- Renamed and implemented new functions for obtaining redshift limits in the galaxy redshift objects: - Changed `nc_galaxy_sd_obs_redshift_get_lim` to `nc_galaxy_sd_obs_redshift_get_gen_lim` for generation limits. - Added `nc_galaxy_sd_obs_redshift_get_integ_lim` for integration limits. - Updated related classes and structures to accommodate the new function signatures and ensure proper functionality. - Updated all relevant files, including: - `nc_galaxy_sd_obs_redshift.c` - `nc_galaxy_sd_obs_redshift.h` - `nc_galaxy_sd_obs_redshift_gauss.c` - `nc_galaxy_sd_obs_redshift_gauss.h` - `nc_galaxy_sd_obs_redshift_pz.c` - `nc_galaxy_sd_obs_redshift_spec.c` - `nc_galaxy_sd_obs_redshift_spec.h` - Test files to reflect the changes in function names and parameters.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
========================================
Coverage 75.34% 75.34%
========================================
Files 599 599
Lines 103621 103780 +159
========================================
+ Hits 78070 78195 +125
- Misses 25551 25585 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixing method/variable names.
Updating tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed and implemented new functions for obtaining redshift limits in the galaxy redshift objects:
nc_galaxy_sd_obs_redshift_get_limtonc_galaxy_sd_obs_redshift_get_gen_limfor generation limits.nc_galaxy_sd_obs_redshift_get_integ_limfor integration limits.Updated all relevant files, including:
nc_galaxy_sd_obs_redshift.cnc_galaxy_sd_obs_redshift.hnc_galaxy_sd_obs_redshift_gauss.cnc_galaxy_sd_obs_redshift_gauss.hnc_galaxy_sd_obs_redshift_pz.cnc_galaxy_sd_obs_redshift_spec.cnc_galaxy_sd_obs_redshift_spec.h