jpas_forecast: make photo-z scatter sigma0 configurable#259
Merged
Conversation
Thread a configurable photo-z scatter normalization (sigma0) through the JPAS forecast generation. Add a --cluster-redshift-sigma0 CLI option (default 0.1) that flows into create_cluster_redshift for the GAUSS relation; NODIST ignores it. Also fix a duplicated docstring line. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 77.47% 77.52% +0.04%
==========================================
Files 665 665
Lines 110904 110905 +1
==========================================
+ Hits 85928 85980 +52
+ Misses 24976 24925 -51 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sigma0) through the JPAS forecast generation.--cluster-redshift-sigma0CLI option (default0.1,min=0.0) that flows intocreate_cluster_redshiftfor the GAUSS relation; NODIST ignores it.create_cluster_redshift.Files
numcosmo_py/app/generate.py— new CLI option, passed through to the generator.numcosmo_py/experiments/jpas_forecast24.py—create_cluster_redshiftacceptssigma0; plumbed throughgenerate_jpas_forecast_2024.🤖 Generated with Claude Code