Fix images not visible at 400% #380
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gathogojr
reviewed
Feb 4, 2025
WanjohiSammy
approved these changes
Feb 5, 2025
marabooy
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Fix images not visible at 400% zoom
Summary: This PR addresses accessibility issues related to images not being properly visible when zoomed to 400% reflow mode. The problem was identified in the OData project, specifically in the context of the "Webinar on Salesforce Connect External Object Reporting" blog. The images below this blog were not displaying correctly when the reflow settings were applied.
Details:
Ensured images scale with the container by setting max-width: 100% and height: auto.
Prevented inline spacing issues by setting display: block.
Centered images within their container using margin: 0 auto.
Improved rendering quality of images with image-rendering: crisp-edges and image-rendering: -webkit-optimize-contrast.
Added a media query for screens with a maximum width of 768px to ensure images fit smaller screens by setting their width to 100% and maintaining their aspect ratio.
Before:
After: