Always include packageName for Hydra study packages - #43
Merged
Merged
Conversation
anthonysena
requested review from
OdysseusMark
and removed request for
OdysseusMark
February 10, 2021 15:48
ssuvorov-fls
self-requested a review
February 11, 2021 09:00
ssuvorov-fls
approved these changes
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per OHDSI/WebAPI#1761, refactoring the Estimation & Prediction designs to ensure that the attribute
packageNameis always included to ensure Hydra works when hydrating a design exported from Atlas/WebAPI.Unrelated to these changes, I modified the pom.xml since I was unable to obtain dependencies from maven central via http. I've revised the pom.xml to reflect the same configuration present in WebAPI for consistency.