Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Duplication in logs #2024 - #2029

Merged
chrisknoll merged 2 commits into
masterfrom
issue-2024_duplicated_lines_in_log
May 6, 2022
Merged

chrisknoll merged 2 commits into
masterfrom
issue-2024_duplicated_lines_in_log

Conversation

@anton-abushkevich

Copy link
Copy Markdown
Contributor

Fixes #2024

@chrisknoll

Copy link
Copy Markdown
Collaborator

It seems that the reason for the duplication is that there's an inherited logging that is being applied such that the child (in this case org.ohdsi is being added to Root, leading to 2 invocations of the Console appender.

Adding additivity="false" prevents that (for the org.ohdsi case) but what about the others?

Should the fix be that if Root is saying to append console, then the others don't need to add the Console appender? Or should all the others also have additivity="false" applied to their <logger> element?

@anton-abushkevich

Copy link
Copy Markdown
Contributor Author

Hi, @chrisknoll

Should the fix be that if Root is saying to append console, then the others don't need to add the Console appender? Or should all the others also have additivity="false" applied to their <logger> element?

I checked both, and either is working. I suggest to add additivity="false" to all loggers - just for the sake of clarity. I committed the changes, please check.

@chrisknoll
chrisknoll merged commit 0985211 into master May 6, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the issue-2024_duplicated_lines_in_log branch May 6, 2022 20:59
@chrisknoll

Copy link
Copy Markdown
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplication in logs

2 participants