Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump up several libraries - #2202

Merged
chrisknoll merged 2 commits into
OHDSI:masterfrom
ecruz165:Bump-libs-listed-as-springboot-2_7-dependencies
Apr 4, 2023
Merged

Bump up several libraries#2202
chrisknoll merged 2 commits into
OHDSI:masterfrom
ecruz165:Bump-libs-listed-as-springboot-2_7-dependencies

Conversation

@ecruz165

@ecruz165 ecruz165 commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

Removed the following unused libraries:

  • org.ehcache:ehcache 3.8.1
  • javax.cache:cache-api 1.0.0
  • commons-httpclient:commons-httpclient 3.1

Upgraded the following to versions provided by SPring Boot 2.7
-- org.apache.commons:commons-lang3 3.9 -> 3.12.0
-- com.google.code.gson:gson 2.8.9 -> 2.9.0
-- com.zaxxer:HikariCP 3.3.1 -> 4.0.3
-- com.microsoft.sqlserver:mssql-jdbc 9.2.1.jre8 -> 10.2.1.jre8

@ecruz165
Removed the following unused libraries:
cfdd74b 
- org.ehcache:ehcache 3.8.1
- javax.cache:cache-api 1.0.0
- commons-httpclient:commons-httpclient 3.1

Upgraded the following to versions provided by SPring Boot 2.7
-- org.apache.commons:commons-lang3 3.9 -> 3.12.0
-- com.google.code.gson:gson 2.8.9 -> 2.9.0
-- com.zaxxer:HikariCP 3.3.1 -> 4.0.3
-- com.microsoft.sqlserver:mssql-jdbc 9.2.1.jre8 -> 10.2.1.jre8
@ecruz165 ecruz165 changed the title Upgraded libraries to versions listed as Spring Boot 2.7 dependencies Bumped up some libraries to versions listed as Spring Boot 2.7 dependencies Feb 8, 2023
@ecruz165 ecruz165 changed the title Bumped up some libraries to versions listed as Spring Boot 2.7 dependencies Bump up several libraries to versions listed as Spring Boot 2.7 dependencies Feb 8, 2023
@chrisknoll

chrisknoll commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

Our Spring Boot version seems to be 1.5 (at least according to this line in the pon):

<spring.boot.version>1.5.22.RELEASE</spring.boot.version>

Will these updates cause a conflict with the current version of spring boot?

@ecruz165

ecruz165 commented Feb 11, 2023

Copy link
Copy Markdown
Contributor Author

@chrisknoll I am aware we are on spring boot 1.5. Maybe the title of PR caused unnecessary concern.

As you might know, spring bundles third-party version numbers of libraries usually paired with spring boot applications to provide features. So I identified the libraries listed in WebAPI that can safely be bumped so that when we arrive at the goal of being on Spring Boot 2.7.x and then we can remove the explicit versioning and let the listed versions listed in Spring Boot handle the upgrading of libraries instead of bumping libs individually.
https://docs.spring.io/spring-boot/docs/2.7.0/reference/html/dependency-versions.html#appendix.dependency-versions

So yes, it is safe to update these libraries> I ran the unit test and the supplied integration tests and all ran to success.

@ecruz165 ecruz165 changed the title Bump up several libraries to versions listed as Spring Boot 2.7 dependencies Bump up several libraries Feb 11, 2023
chrisknoll
chrisknoll requested changes Feb 11, 2023
View reviewed changes

@chrisknoll chrisknoll left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(deleted)

chrisknoll
chrisknoll requested changes Feb 11, 2023
View reviewed changes
Comment thread pom.xml Outdated
@ecruz165
ecruz165 requested a review from chrisknoll February 24, 2023 18:11
@anthonysena

anthonysena commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

These changes are related to upgrading WebAPI to Spring Boot 2.x

@chrisknoll
chrisknoll merged commit 7fcd21f into OHDSI:master Apr 4, 2023
@chrisknoll chrisknoll added this to the v2.14 milestone Apr 4, 2023
@anthonysena anthonysena linked an issue Apr 4, 2023 that may be closed by this pull request
Upgrade to Spring Boot 2.3 #2244
Open
@anthonysena anthonysena removed this from the v2.14 milestone Apr 4, 2023
pieterlukasse pushed a commit to pieterlukasse/WebAPI that referenced this pull request Sep 6, 2023
Edwin Cruz @pieterlukasse
Bump up several libraries (OHDSI#2202)
a102b1e 
* Removed the following unused libraries:
- org.ehcache:ehcache 3.8.1
- javax.cache:cache-api 1.0.0
- commons-httpclient:commons-httpclient 3.1

Upgraded the following to versions provided by SPring Boot 2.7
-- org.apache.commons:commons-lang3 3.9 -> 3.12.0
-- com.google.code.gson:gson 2.8.9 -> 2.9.0
-- com.zaxxer:HikariCP 3.3.1 -> 4.0.3
-- com.microsoft.sqlserver:mssql-jdbc 9.2.1.jre8 -> 10.2.1.jre8

* Removing unnecessary comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisknoll chrisknoll chrisknoll approved these changes
@anthonysena anthonysena anthonysena approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
Atlas/WebAPI v2.14
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Spring Boot 2.3

3 participants

@ecruz165 @chrisknoll @anthonysena