Switch isNumeric() to anayisID test when casting. - #2209
Merged
Merged
Conversation
Collaborator
Author
|
@alondhe , this PR is in draft so that you can test this branch in your own env. If it works for you, we'll make it a formal PR. |
Contributor
|
Thanks @chrisknoll -- will review here and deploy in our test environment by early next week. |
Collaborator
Author
|
@alondhe, any results? |
alondhe
self-requested a review
February 22, 2023 22:41
alondhe
marked this pull request as ready for review
February 22, 2023 22:41
alondhe
approved these changes
Feb 22, 2023
alondhe
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay, @chrisknoll! Been fighting with our tech stack and OS permissions.
I tested by re-inserting our benchmark records into achilles_results and achilles_results_dist. In Atlas 2.12.1, the drilldowns throughout each domain would error out with the Redshift error I described.
Using this branch, I tried the same tests and never came across the Redshift errors. I also checked that the values from the Achilles tables match what's in the report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2187.
These changes span a large number of files. I did not change any files related to heracles reports (these should probably be deprecated).
The general strategy is moving away from isNumeric() and instead depending on the record's
analysis_idto determine how the casting should perform. The problem with isNumeric() is that numeric values like '123.45' were passign the isNumeric() test, but can not be casted to an integer. By using analysis_id you can be certain that the cast you are doing is appropriate to the analysis that generated the record.