Refactored imports to depend on org.apache.commons:commons-lang3 - #2215
Merged
Conversation
… replaced existing references with newer library variant.
anthonysena
approved these changes
Apr 4, 2023
Collaborator
|
These changes are related to upgrading to Spring Boot 2.x |
Collaborator
|
@ecruz165 - can you resolve the conflicts and then we can merge this into |
Collaborator
|
Discussion on this from the Atlas WG - we'll revisit this in the next release when the SOLR work is completed since there is a merge conflict on that file at the moment. |
Collaborator
|
Associating with OHDSI/StandardizedAnalysisAPI#54 |
Collaborator
|
@ecruz165 - just following up here to see if you can resolve the merge conflicts? We can the put this into the v2.15 release. Thanks! |
chrisknoll
changed the base branch from
master
to
ohdsi-removed-dependency-on-commons-lang
November 27, 2024 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw we are using in code references to commons-lang and commons-lang3. I removed dependency on commons-lang, removed any unused imports in files i updated. And I introduced commons-text to support usage of WordUtils that was moved to that library.