Webapi docker profile and TLS - #2235
Merged
Merged
Conversation
In docker-webapi profile
Removed duplicate repo entries; added ohdsi.snapshot entry
Collaborator
chrisknoll
approved these changes
Apr 13, 2023
pieterlukasse
pushed a commit
to pieterlukasse/WebAPI
that referenced
this pull request
Sep 6, 2023
* Changed non-TLS nexus to use TLS * Removed duplicate repo entries; added ohdsi.snapshot entry Fixes OHDSI#2230.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2230
In this PR version, I've removed the extra maven and ohdsi repo entries for the webapi-docker profile.
However, I have added a repo entry for ohdsi snapshots. This ensures that all snapshots from the ohdsi repo are handled with TLS enabled, and doesn't revert to using snapshots on the non-TLS sites.