Add a name of a person who kicked off a job (Atlas #750) - #500
Merged
Merged
Conversation
chrisknoll
approved these changes
Jul 5, 2018
| */ | ||
| package org.ohdsi.webapi.service; | ||
|
|
||
| import static java.lang.String.format; |
Collaborator
There was a problem hiding this comment.
I dislike using static imports for this type of call. See below.
| .ok(baos) | ||
| .type(MediaType.APPLICATION_OCTET_STREAM) | ||
| .header("Content-Disposition", String.format("attachment; filename=\"%s\"", "ir_analysis_" + id + ".zip")) | ||
| .header("Content-Disposition", format("attachment; filename=\"%s\"", "ir_analysis_" + id + ".zip")) |
Collaborator
There was a problem hiding this comment.
import static lets you call format(), but it makes it look like it's a locally defined function. Is it really a hardship to type 'String.format'?
TomWhite-MedStar
added a commit
to TomWhite-MedStar/WebAPI
that referenced
this pull request
Apr 25, 2023
…s concatenated with report OHDSI#500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue from Atlas repository - OHDSI/Atlas#750