os2web_key #1
Merged
os2web_key #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d2f117 to
76bdd06
Compare
cableman
requested changes
May 7, 2024
| /** | ||
| * Runtime exception. | ||
| */ | ||
| class RuntimeException extends \RuntimeException { |
There was a problem hiding this comment.
Would it be better to rename this exception to something like ModuleRuntimeExeception or SSLRuntimeException?
There was a problem hiding this comment.
That would not add any value. The RuntimeException is namespaced and can be aliased (use … as …) if need be.
| * {@inheritdoc} | ||
| */ | ||
| public function validateConfigurationForm(array &$form, FormStateInterface $form_state): void { | ||
| } |
There was a problem hiding this comment.
Empty validation function, would it be possible to validate the Passphrase for the certificate in some way if one is given?
There was a problem hiding this comment.
Actual validation is performed in validateKeyValue. I've added a comment telling this in 0eb16ad.
cableman
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
os2web_keymodule. See https://github.com/OS2web/os2web_key/blob/os2web_key/README.md for details.