Add selectingParentSelectsChildren argument #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… computed property
…ected computed property
…ngParentSelectsChildren is false
…ion array if selectingParentSelectsChildren is false
|
Closing as design changed their mind about this behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have a use case where we want to be able to select a parent row without its children rows getting selected.
This MR adds a
selectingParentSelectsChildrenargument to theember-tbodycomponent which defaults totrue. When setting this argument tofalse, selecting a parent node won't select the node's children.An assertion has been added to disallow setting
selectingParentSelectsChildrentofalsewhileselectingChildrenSelectsParentistruesince this would result in weird edge cases where sometimes the parent row has influence on the children and sometimes not.Some examples of use cases on the web where this also happens: MUI tree view, react-checkbox-tree No Cascade Example.
How to test?
Take a look at the Prism MR: https://git.otainsight.com/ota-insight-repos/ota-insight-platform/ota-insight-frontend/prism/-/merge_requests/1029