Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automatic module name not included in manifest #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
afloarea opened this issue Apr 1, 2023 · 2 comments · Fixed by #77
Closed

Automatic module name not included in manifest #66

afloarea opened this issue Apr 1, 2023 · 2 comments · Fixed by #77

Comments

@afloarea
Copy link

afloarea commented Apr 1, 2023 •
edited
Loading

Hello,

I have tried using the core encoder in a project with java9+ modules but the automatic module name is missing from the jar manifest, version 1.2.3, (even though I saw some configuration in the pom.xml for the automatic module name manifest entry):

Manifest-Version: 1.0
Bundle-Description: The OWASP Encoders package is a collection of high
 -performance low-overhead        contextual encoders, that when utili
 zed correctly, is an effective tool in        preventing Web Applicat
 ion security vulnerabilities such as Cross-Site        Scripting.
Bundle-License: http://www.opensource.org/licenses/BSD-3-Clause
Bundle-SymbolicName: org.owasp.encoder
Built-By: jeremy
Bnd-LastModified: 1604861240860
Bundle-ManifestVersion: 2
Bundle-DocURL: https://www.owasp.org/
Bundle-Vendor: OWASP (Open Web-Application Security Project)
Tool: Bnd-3.3.0.201609221906
Originally-Created-By: Apache Maven Bundle Plugin
Export-Package: org.owasp.encoder;version="1.2.3"
Bundle-Name: Java Encoder
Bundle-Version: 1.2.3
Created-By: Apache Maven Bundle Plugin
Build-Jdk: 1.8.0_212

Extra:
Have you considered using multi-release jars to include module-info.java file for java9+? It seems straightforward (for the core subproject at least) since it only has 1 package and no dependencies (and requires using a jdk9+). I might be missing something regarding OSGi though.
Diff

In any case, thank you for maintaning this project.
jeremylong added a commit that referenced this issue Jul 28, 2024
@jeremylong
feat: multi-release jars - add module name
a1278e1 
resolves #66
@jeremylong jeremylong mentioned this issue Jul 28, 2024
Merged
@jeremylong
Copy link
Member

@kwwall see #77 - does ESAPI have a java 9 module name we need to add a requires for?

jeremylong added a commit that referenced this issue Jul 30, 2024
@jeremylong
feat: multi-release jars - add module name (#77)
2f151ce 
resolves #66
@kwwall
Copy link
Contributor

kwwall commented Jul 30, 2024

@kwwall see #77 - does ESAPI have a java 9 module name we need to add a requires for?

@jeremylong - Sorry for the late reply. I was AFKB over the weekend to attend a funeral. ESAPI supports JDK 8 as the minimal JDK, so we didn't think it made sense to specify a module-info.java and a module name. So, no; there is nothing you need to add for ESAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: multi-release jars - add module name OWASP/owasp-java-encoder
3 participants
@jeremylong @kwwall @afloarea