Added error decoder to async builder #2029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
Co-authored-by: Richard Wagstaff <[email protected]>
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Co-authored-by: Richard Wagstaff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a error decoder to the async builder when building from the coroutine builder
This was fixed by adding the error decoder to the async builder
How to replicate
Create a feign client with a custom error decoder
val feignClient: FeignPriceClient = CoroutineFeign.builder<Unit>().errorDecoder(CustomErrorDecoder()) .target(FeignPriceClient::class.java, "http://localhost:8080/")The custom error decoder is lost when building the async client