Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@codefromthecrypt
Copy link
Contributor

Based on discussions, it seems guava is not a good candidate as a dependency for highly reusable software. While switching off guava adds ~200 lines of code, it removes risk of version conflicts systemic to the guava ecosystem. Eventhough JAX-RS is a relatively stable dep, there's a new version 2.0 which implies another possible version clash.

This change introduces new @RequestLine and @Headers annotations and moves jax-rs support to an optional module.

ex.

interface GitHub {
  @RequestLine("GET /repos/{owner}/{repo}/contributors")
  @Headers({
    "Accept: application/json",
    "User-Agent: feign/2.0.0",
  })
  List<Contributor> contributors(@Named("owner") String owner, @Named("repo") String repo);
}

cc @allenxwang @benjchristensen

@codefromthecrypt
Copy link
Contributor Author

well the intent is no deps except dagger api, which is only 5 classes.

@codefromthecrypt
Copy link
Contributor Author

updated to bump jax-rs to an optional extension; revised desc

@cloudbees-pull-request-builder

feign-pull-requests #15 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Jul 1, 2013
to facilitate higher reuse, remove guava and jax-rs deps
@codefromthecrypt codefromthecrypt merged commit ab20ed0 into master Jul 1, 2013
@codefromthecrypt codefromthecrypt deleted the no-guava branch July 1, 2013 16:15
@benjchristensen
Copy link

+1

velo pushed a commit that referenced this pull request Oct 8, 2024
to facilitate higher reuse, remove guava and jax-rs deps
velo pushed a commit to hosuaby/feign that referenced this pull request Nov 4, 2024
Rebased and updated: OSCR-849 Enabling the option to use HTTPS/2 for REST calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants