Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🩹 Remove duplicate title in individual summaries #89

Merged
SirusCodes merged 1 commit into
OurTechCommunity:mainfrom
sreekaransrinath:fix-double-title
Oct 14, 2022
Merged

🩹 Remove duplicate title in individual summaries #89
SirusCodes merged 1 commit into
OurTechCommunity:mainfrom
sreekaransrinath:fix-double-title

Conversation

@sreekaransrinath

@sreekaransrinath sreekaransrinath commented Oct 9, 2022

Copy link
Copy Markdown
Contributor
  • condense about section

Fixes #71

@sreekaransrinath

Copy link
Copy Markdown
Contributor Author

cc @HarshKapadia2

Comment thread summary/individual-summary.adoc
@SirusCodes

Copy link
Copy Markdown
Member

@tusharnankani have a look and merge of looks fine to you as well

@sreekaransrinath

Copy link
Copy Markdown
Contributor Author

@KartikSoneji @HarshKapadia2 requesting review

@tusharnankani tusharnankani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright. Thank you, Sreekaran!

@KartikSoneji KartikSoneji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SirusCodes SirusCodes merged commit 8ddcf73 into OurTechCommunity:main Oct 14, 2022
@KartikSoneji

Copy link
Copy Markdown
Member

Just realised, this doesn't actually fix the duplicate title in the individual summary page.

@sreekaransrinath

Copy link
Copy Markdown
Contributor Author

@KartikSoneji what do you mean?

@tusharnankani

Copy link
Copy Markdown
Member

Ah damn, okay.

In #71, the issue is to remove the redundant OTC CatchUp #90 Summary.

@sreekaransrinath

sreekaransrinath commented Oct 18, 2022

Copy link
Copy Markdown
Contributor Author

I see what it is -

The first title comes from the individual-summary.adoc line 1.

The second is from combined-summary-template.adoc line 1.

Can someone confirm that the only purpose of the combined summary template is to serve inside the individual summary page?

I can delete either and send in a PR, but deleting the one in the template might have unintended consequences if it also serves elsewhere.

@sreekaransrinath

Copy link
Copy Markdown
Contributor Author

Bump @KartikSoneji @tusharnankani

@KartikSoneji

Copy link
Copy Markdown
Member

Can someone confirm that the only purpose of the combined summary template is to serve inside the individual summary page?

No. The combined summary template is also used to build, well, the combined summary.

The fix will be a bit more involved with this one, I'll leave a comment with more details on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTC CatchUp ## Summary is not needed twice

4 participants