Overcoat only requires PMKPromise, not all of PMK#85
Merged
Conversation
Should you ever need more of PromiseKit it’s easy to add more subspecs.
Member
|
@mxcl thanks! 👍 |
|
When I was using Overcoat 2.1.1, cocoa pods installed PromiseKit 1.5.3... from your spec. Now it seems to be going backwards that Overcoat 3.0 uses PromiseKit 1.2...? Also, the Latest PromiseKit is 2.1.. is that suppose to be in Overcoat 3, (just transposed the numbers)? |
Member
|
Hi @numerics, the version specified in the I don't really use PromiseKit, but I could still try to adopt the Overcoat to compatible with the newest PromiseKit. You're welcome to submit a PR for this too. 😄 |
Contributor
Author
|
I could submit a PR to upgrade to 2.x, it probably is minimal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should you ever need more of PromiseKit it’s easy to add more subspecs.