Add extra braces when setting VkClearValue#247
Merged
Overv merged 1 commit intoOverv:masterfrom Jul 24, 2021
Merged
Conversation
Overv
added a commit
that referenced
this pull request
Mar 8, 2023
Add extra braces when setting VkClearValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clang++ -Wallemits the warning "suggest braces around initialization of subobject [-Wmissing-braces]" with code likeVkClearValue clearColor = {0.0f, 0.0f, 0.0f, 1.0f};Since this is trying to fill out
clearColor.color.float32, 3 braces are needed likeVkClearValue clearColor = {{{0.0f, 0.0f, 0.0f, 1.0f}}};to avoid the warning.