Load models section needs vertex colors#26
Merged
Overv merged 1 commit intoOverv:masterfrom Oct 14, 2016
Merged
Conversation
When running the given examples I had an all black screen. I realized the shader was still multiplying the texture and vertex colors. An alternative solution would be to modify the fragment shader, but felt it was better to provide proper Vertex attributes.
Owner
|
Ah, I didn't really intend people to copy the final snippet of the texture mapping tutorial to their own shader code. This is a good solution, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the given examples I had an all black screen.
I realized the shader was still multiplying the texture and vertex
colors. This sets each color to white as they are loaded from the obj.
An alternative solution would be to modify the fragment shader,
but felt it was better to provide proper Vertex attributes.