Add virtual packages for seal adapters #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dfefea to
7875150
Compare
Toflar
approved these changes
Nov 19, 2025
Member
Toflar
left a comment
There was a problem hiding this comment.
I don't think we're going to use it in Contao after all but in any case, I think this is the right step for whoever builds a package that depends on SEAL and thus on at least one adapter 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All seal adapters will provide
cmsig/seal-adapter-implementation.All seal adapters in core go with:
Custom adapters need provide the related / supported
cmsig/sealversion:As I personally not a big fan of the virtual packages we will currently not require them in our
integrationpackages. But third party are this way free to require it to make composer fail if no adapter was required by the project / library.This should help eventuall a future
contao/backend-search-bundlepackage to require"cmsig/seal-adapter-implementation": "^0.12"if they want that behaviour.