Setupwithseeddata#64
Merged
Merged
Conversation
eseiver
suggested changes
Dec 23, 2017
eseiver
left a comment
Collaborator
There was a problem hiding this comment.
One question about commented-out line.
| 'allofplos.seed_corpus': ['*.xml'], | ||
| }, | ||
|
|
||
| #include_package_data=True, |
Collaborator
There was a problem hiding this comment.
Is this line needed un-commented out?
Contributor
Author
There was a problem hiding this comment.
This line is deleted because is not needed. It is used in conjunction with MANIFEST.in file, but this is for previous Python version (less than 3), since we don't support <3, it is not needed.
Here more information http://setuptools.readthedocs.io/en/latest/setuptools.html#including-data-files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the data installable, both the xml files and the SQLite DB.