use os.path.basename() in filename_to_doi#87
Merged
Conversation
mpacer
reviewed
Feb 27, 2018
| """ | ||
| if correction in filename and validate_filename(filename): | ||
| article = 'annotation/' + (filename.split('.', 4)[2]) | ||
| article = 'annotation/' + ((os.path.basename(filename)).split('.', 4)[2]) |
Collaborator
There was a problem hiding this comment.
Why not do filename = os.path.basename(filename) before if correction in filename and validate_filename(filename):?
Collaborator
|
interactive rebase to squash these into one commit? then it looks good to go. |
Collaborator
|
Closes #84 |
90472c8 to
02f07ee
Compare
Contributor
|
Thank you! |
This was referenced Feb 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the bug @egh found in #84.
to handle the full filepath,
os.path.basenamemust be used for the filename to DOI transformation to work.