-
Notifications
You must be signed in to change notification settings - Fork 204
Refactor solver #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor solver #233
Conversation
Thanks for your contribution! |
ppsci/solver/solver.py
Outdated
|
||
pretrained_model_path = cfg["Global"].get("pretrained_model_path", None) | ||
log_level = cfg["Global"].get("log_level", "info") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add config checker
|
2. support grad scaler in save_load.py 3. adjust default checkpoint directory
c1dea05
to
f5008dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with todo:
- add config checker
…_stokes.py; 3. replace f-string with string if f-string has no placeholders
f670a19
to
862076b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Function optimization
PR changes
APIs
Describe
create_train_solver_from_args
,create_eval_solver_from_args
,create_train_solver_from_config
,create_eval_solver_from_config