Refactored code from encoders.vhdl into inenc and outenc .vhdl#241
Draft
adedamola-sode wants to merge 2 commits into
Draft
Refactored code from encoders.vhdl into inenc and outenc .vhdl#241adedamola-sode wants to merge 2 commits into
adedamola-sode wants to merge 2 commits into
Conversation
tomtrafford
reviewed
Jul 11, 2025
Contributor
There was a problem hiding this comment.
Can you remove the signals that are declared but not used. I suspect most of the ones in encoders.vhd should no longer be there.
tomtrafford
reviewed
Jul 11, 2025
| Bs0_pad_io => Bs0_pad_io, | ||
| Zs0_pad_io => Zs0_pad_io, | ||
| -- Block inputs | ||
| GENERATOR_ERROR_i=> GENERATOR_ERROR_i, |
Contributor
There was a problem hiding this comment.
A minor style preference, but could you add in some white space so that all '=>'s line up with at least a single space on either side of the operator?
tomtrafford
reviewed
Jul 11, 2025
| ); | ||
|
|
||
|
|
||
| -- Determine how to share between inenc and outenc |
Contributor
There was a problem hiding this comment.
There's a couple of comments you've added in the file here... Does something still need to be done, or could you remove the comments.
Contributor
|
FYI there are external issues with the runners atm, so the CI won't run. It's being looked into. |
ecbd85b to
27f6902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code from encoder.vhd has been split into inenc and outenc .vdl respectively. Tested on p99 panda, but needs validation.