Implementing circular stack for Command Stack #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks a lot for the PR! Since the engine isn’t used for game development yet, there’s no need to worry too much about perfection. For example, I’m happy with how max_undo_steps is hardcoded, its nature doesn't require anything else, and simplicity is key, just as mentioned in the coding style\general advice. Your work is a nice step forward, feel free to proceed. I’m ready to merge when you are. |
Contributor
Author
|
Thanks, it's ready to be merged. |
Owner
|
I agree, thanks! |
Owner
|
I reached out on X, please check. |
PanosK92
added a commit
that referenced
this pull request
Jan 12, 2025
Implementing circular stack for Command Stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added CircularStack, which is a fixed size stack that goes around if there is no more space to add new items.
It's related to the comment:
I am sure we can make it even better by using only 1 stack instead of 2 for undo and redo commands. But I just wanted to make the initial step. I am not a game dev, but I like implementing data structures, so here it is.
Code is tested in my another project works fine. Currently, size type is hard-coded based on
max_undo_stepstype, but it can also be put into a template later.Waiting for a feedback.