Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Nov 29, 2016

Note: Github makes the file-renaming in this PR look like 'changes' but code functionality hasn't really changed for the most part, mostly code has been moved around.

  1. 'yconf' dependency introduced to control configuration, wrapped by Common/Config.py.
  2. Common/Config.py added: wraps 'yconf' and will 'ask' each submodule if they have config flags, allowing configuration flags to be defined in submodules (instead of a static location). Config.py checks for 'required' config fields because yconf can't do this properly for both config and/or cmdline based values.
  3. setup.py updated to use 'setuptools' (the new way) and classifiers added for PyPi to index.
  4. README.md converted to README.rst to be PyPi compatible, no visual differences on github (supports .rst too).
  5. Several code files moved to submodules (without functional change).
  6. Makefile updated to use globs instead of a huge list of paths.
  7. 'Config' object is passed around to different modules instead of many variables.
  8. Version set to 1.0.0.

After further changes/tweaks, there will need to be more testing on this branch, specifically optional areas like:

  • S3 Upload
  • NSCA Notifications
  • Failure Cases (Auth failed, Connect failed, pre-3.2 'mongodump' binary, etc)

@timvaillancourt timvaillancourt changed the title Moving to yaml-nested (or command-line based) configuration and modular (sub)class-ing MCB_1.0: Moving to yaml-nested (or command-line based) configuration and modular (sub)class-ing Nov 29, 2016
@dbmurphy
Copy link
Contributor

dbmurphy commented Dec 5, 2016

👍

Approved with PullApprove

@dbmurphy dbmurphy merged commit 0d689a7 into Percona-Lab:MCB_1.0 Dec 5, 2016
@timvaillancourt timvaillancourt deleted the yaml_nested branch March 30, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants