From victor@drawall.cc

0002-test-Add-regex-tests.patch

From 648d5fc4a052dab62bdcc9f28af234b0ab163063 Mon Sep 17 00:00:00 2001
From: Victor Adam <victor@drawall.cc>
Date: Fri, 2 Oct 2015 19:35:19 +0200
Subject: [PATCH 2/3] test: Add regex tests

This adds tests for RT tickets #126177, #126178, #126179, #126180, #126185,
 #126181, #126186, #126187 and #126222.
---
 t/re/re_tests     | 45 +++++++++++++++++++++++++++++++++++++++++++++
 t/re/regex_sets.t | 19 +++++++++++++++++++
 t/re/regexp.t     |  1 +
 3 files changed, 65 insertions(+)

diff --git a/t/re/re_tests b/t/re/re_tests
index 9d5fa73..7d83ee1 100644
--- a/t/re/re_tests
+++ b/t/re/re_tests
@@ -1926,5 +1926,50 @@ A+(*PRUNE)BC(?{})	AAABC	y	$&	AAABC
 
 /(a+){1}+a/	aaa	n	-	-		# [perl #125825]
 
+# RT #126178: these should cause a syntax error
+(?i		Bc	-	Unmatched (
+(?^		Bc	-	Unmatched (
+(?-		Bc	-	Unmatched (
+(?a-a		Bc	-	Unmatched (
+
+# RT #126177: (?n) should disable numbered captures
+(?n)(abc)	abc	y	-$1	-
+'(?-n)(abc)'n	abc	y	-$1	-abc
+
+# RT #126179: \N{} should cause an error (even when skipping the lexer)
+[\N{}]		Bc	-	Zero length \N{}
+
+# RT #126180: those segfault inside (?[])
+[\ &!]		Bsc	-	Incomplete expression
+[\ +!]		Bsc	-	Incomplete expression
+[\ -!]		Bsc	-	Incomplete expression
+[\ ^!]		Bsc	-	Incomplete expression
+[\ |!]		Bsc	-	Incomplete expression
+
+# RT #126185: (?-p) should be an error
+(?-p)		Bc	-	Regexp modifier \"a\" may not appear after the \"-\"
+'(?-p)'p		Bc	-	Regexp modifier \"a\" may not appear after the \"-\"
+
+# RT #126186: (*ACCEPT:arg) should either be an error or set $REGMARK correctly
+(*MARK:arg)		y	$REGMARK	arg
+(*ACCEPT:arg)		By	$REGMARK	arg
+
+# RT #126187: these produce warnings (even when skipping the tests!)
+# \p 		c	-	Can't find Unicode property	TODO
+# \p^		c	-	Can't find Unicode property	TODO
+# \P 		c	-	Can't find Unicode property	TODO
+# \P^		c	-	Can't find Unicode property	TODO
+
+# RT #126222
+(?(?!))		By	-	-
+
+# RT #126253
+.{1}??		Bc	-	Nested quantifiers
+.{1}?+		Bc	-	Nested quantifiers
+.{1}+?		c	-	Nested quantifiers
+.{1}++		c	-	Nested quantifiers
+.{1}*?		c	-	Nested quantifiers
+.{1}*+		c	-	Nested quantifiers
+
 # Keep these lines at the end of the file
 # vim: softtabstop=0 noexpandtab
diff --git a/t/re/regex_sets.t b/t/re/regex_sets.t
index ee161b2..185c70f 100644
--- a/t/re/regex_sets.t
+++ b/t/re/regex_sets.t
@@ -138,6 +138,25 @@ if (! is_miniperl() && locales_enabled('LC_CTYPE')) {
     }
 }
 
+# RT #126181: \cX behaves strangely inside (?[])
+{
+	no warnings qw(syntax regexp);
+
+	eval { $_ = '/(?[(\c]) /'; qr/$_/ };
+	like($@, qr/^Syntax error/, '/(?[(\c]) / should not panic');
+	eval { $_ = '(?[\c#]' . "\n])"; qr/$_/ };
+	like($@, qr/^Syntax error/, '/(?[(\c]) / should not panic');
+	eval { $_ = '(?[(\c])'; qr/$_/ };
+	like($@, qr/^Syntax error/, '/(?[(\c])/ should be a syntax error');
+	eval { $_ = '(?[(\c]) ]\b'; qr/$_/ };
+	like($@, qr/^Syntax error/, '/(?[(\c]) ]\b/ should be a syntax error');
+	eval { $_ = '(?[\c[]](])'; qr/$_/ };
+	like($@, qr/^Syntax error/, '/(?[\c[]](])/ should be a syntax error');
+	like("\c#", qr/(?[\c#])/, '\c# should match itself');
+	like("\c[", qr/(?[\c[])/, '\c[ should match itself');
+	like("\c\ ", qr/(?[\c\])/, '\c\ should match itself');
+	like("\c]", qr/(?[\c]])/, '\c] should match itself');
+}
 
 done_testing();
 
diff --git a/t/re/regexp.t b/t/re/regexp.t
index f27a027..cbac03f 100644
--- a/t/re/regexp.t
+++ b/t/re/regexp.t
@@ -99,6 +99,7 @@ use strict;
 use warnings FATAL=>"all";
 use vars qw($bang $ffff $nulnul); # used by the tests
 use vars qw($qr $skip_amp $qr_embed $qr_embed_thr $regex_sets); # set by our callers
+use vars qw($REGMARK); # set from tested patterns
 
 
 
-- 
2.5.3

regex: \c inside (?[]) causes panics and unexpected behavior #14934

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions