Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Even smaller toke #17241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Nov 4, 2019
Merged

Even smaller toke #17241

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4cfd4be
toke.c: factor out static yyl_fake_eof()
arc Oct 21, 2019
20b318f
toke.c: factor out static yyl_fatcomma()
arc Oct 21, 2019
0ac6054
toke.c: fold some initialisations into the corresponding declarations
arc Oct 21, 2019
f5417bd
toke.c: factor out static yyl_safe_bareword()
arc Oct 21, 2019
305b85e
toke.c: factor out static yyl_constant_op()
arc Oct 21, 2019
1fd0b21
toke.c: remove the really_sub goto label
arc Oct 21, 2019
be24a7d
toke.c: factor out static yyl_strictwarn_bareword()
arc Oct 21, 2019
eac79f6
toke.c: stop passing around several needless local variables
arc Oct 22, 2019
cd77589
toke.c: factor out static yyl_just_a_word()
arc Oct 23, 2019
539c839
toke.c: bundle some yyl_just_a_word() params into a struct
arc Oct 23, 2019
941cf49
toke.c: factor out static yyl_key_core() and yyl_word_or_keyword()
arc Oct 23, 2019
a5ed768
toke.c: factor out static yyl_keylookup()
arc Oct 23, 2019
c2b7184
toke.c: delete weird initial_state arg to yyl_try()
arc Oct 23, 2019
6e93a30
toke.c: remove formbrack argument from yyl_try()
arc Oct 23, 2019
d333554
toke.c: remove some spurious orig_keyword uses
arc Oct 23, 2019
b6c215b
toke.c: don't pass around a copy of PL_parser->saw_infix_sigil
arc Oct 25, 2019
3fca6a0
toke.c: delete unused bof parameters
arc Oct 25, 2019
6a78cc1
toke.c: replace recursive calls to yyl_try() with goto
arc Nov 1, 2019
1732dbb
toke.c: const-ify formbrack parameters
arc Nov 1, 2019
18828ce
perldelta for recent toke.c refactoring
arc Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
toke.c: factor out static yyl_safe_bareword()
  • Loading branch information
@arc
arc committed Nov 4, 2019
commit f5417bd96886c039469e82f67f4f10c44e904b84
34 changes: 20 additions & 14 deletions toke.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7094,6 +7094,24 @@ yyl_fatcomma(pTHX_ char *s, STRLEN len)
TERM(BAREWORD);
}

static int
yyl_safe_bareword(pTHX_ char *s, const char lastchar, const bool saw_infix_sigil)
{
if ((lastchar == '*' || lastchar == '%' || lastchar == '&')
&& saw_infix_sigil)
{
Perl_ck_warner_d(aTHX_ packWARN(WARN_AMBIGUOUS),
"Operator or semicolon missing before %c%" UTF8f,
lastchar,
UTF8fARG(UTF, strlen(PL_tokenbuf),
PL_tokenbuf));
Perl_ck_warner_d(aTHX_ packWARN(WARN_AMBIGUOUS),
"Ambiguous use of %c resolved as operator %c",
lastchar, lastchar);
}
TOKEN(BAREWORD);
}

static int
yyl_try(pTHX_ char initial_state, char *s, STRLEN len,
I32 orig_keyword, GV *gv, GV **gvp,
Expand Down Expand Up @@ -7795,7 +7813,7 @@ yyl_try(pTHX_ char initial_state, char *s, STRLEN len,

/* And if "Foo::", then that's what it certainly is. */
if (safebw)
goto safe_bareword;
return yyl_safe_bareword(aTHX_ s, lastchar, saw_infix_sigil);

if (!off)
{
Expand Down Expand Up @@ -8031,19 +8049,7 @@ yyl_try(pTHX_ char initial_state, char *s, STRLEN len,
}
op_free(rv2cv_op);

safe_bareword:
if ((lastchar == '*' || lastchar == '%' || lastchar == '&')
&& saw_infix_sigil) {
Perl_ck_warner_d(aTHX_ packWARN(WARN_AMBIGUOUS),
"Operator or semicolon missing before %c%" UTF8f,
lastchar,
UTF8fARG(UTF, strlen(PL_tokenbuf),
PL_tokenbuf));
Perl_ck_warner_d(aTHX_ packWARN(WARN_AMBIGUOUS),
"Ambiguous use of %c resolved as operator %c",
lastchar, lastchar);
}
TOKEN(BAREWORD);
return yyl_safe_bareword(aTHX_ s, lastchar, saw_infix_sigil);
}

case KEY___FILE__:
Expand Down