DynaLoader: dl_dyld.xs: don't undef bool #21818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I expect this was added when we added our own bool, and before we used bool so liberally ourselves. Now dl_dyld.xs fails to compile, since MY_CXT_CLONE indirectly uses UNLIKELY() which casts to bool. Tested locally with: ./Configure -des -Dusedevel -Dusethreads -Ddlsrc=dl_dyld.xs on a modern Darwin, which failed before this change and builds after. Based on work done by Sevan Janiyan in Perl#21751. Fixes Perl#21751
|
LGTM. Thanks. |
Thanks for checking that. @tonycoz, would you like to proceed with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect this was added when we added our own bool, and before we used bool so liberally ourselves. Now dl_dyld.xs fails to compile, since MY_CXT_CLONE indirectly uses UNLIKELY() which casts to bool.
Tested locally with:
./Configure -des -Dusedevel -Dusethreads -Ddlsrc=dl_dyld.xs
on a modern Darwin, which failed before this change and builds after.
Based on work done by Sevan Janiyan in #21751.
Fixes #21751