Avoid generating bindings for non-perf types and constants #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current way of generating bindings via bindgen creates entries for any type or constant that is reachable when including the headers listed in wrapper.h. In addition to the perf-related structs we care about, this includes: - A variety of unrelated kernel API types - A bunch of constants used as implementation details for making ioctls - A constant for every single syscall number - ... and more besides There is no reason to include these in the generated bindings. Once present, however, removing or changing them becomes a breaking change. This is a one-shot change that changes the generation to only keep the relevant structs. This is a breaking change and would require a perf-event-open-sys2 v6.0.0.
5b7a928 to
8af965e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of generating bindings via bindgen creates entries for any type or constant that is reachable when including the headers listed in wrapper.h. In addition to the perf-related structs we care about, this includes:
There is no reason to include these in the generated bindings. Once present, however, removing or changing them becomes a breaking change. This is a one-shot change that changes the generation to only keep the relevant structs.
This is a breaking change and would require a perf-event-open-sys2 v6.0.0.