Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[noetic] Adding missing dependency (interactive_markers) #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2020
Merged

[noetic] Adding missing dependency (interactive_markers) #168

merged 2 commits into from
Sep 5, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Sep 4, 2020

This is a follow up for moveit/moveit_visual_tools#75.

@seanyen seanyen mentioned this pull request Sep 4, 2020
Closed
rhaschke
rhaschke approved these changes Sep 5, 2020
View reviewed changes
Copy link

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. Would you mind to insert interactive_markers at the correct position in the alphabetically ordered list of packages? Thanks.

@seanyen
Copy link
Contributor Author

seanyen commented Sep 5, 2020

Would you mind to insert interactive_markers at the correct position in the alphabetically ordered list of packages? Thanks.

@rhaschke Done. I added it to the correct order in the CMakeLists.txt. For the package.xml, since the original list is not sorted so I kept the new addition to the end.

@JafarAbdi JafarAbdi merged commit 9b8f303 into PickNikRobotics:noetic-devel Sep 5, 2020
@JafarAbdi
Copy link
Collaborator

CI is failing due to clang-format which is unrelated to this PR

tylerjw pushed a commit that referenced this pull request Oct 2, 2020
@seanyen @tylerjw
Adding missing dependency (interactive_markers) (#168)
c16bd79
JafarAbdi pushed a commit that referenced this pull request Oct 5, 2020
@seanyen @JafarAbdi
Adding missing dependency (interactive_markers) (#168)
1a05483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

@JafarAbdi JafarAbdi JafarAbdi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanyen @JafarAbdi @rhaschke