spin independent thread for RemoteControl #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4hn
commented
Aug 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
- Coverage 19.83% 19.81% -0.03%
==========================================
Files 5 5
Lines 1699 1701 +2
==========================================
Hits 337 337
- Misses 1362 1364 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Avoid deadlocks and cross-thread effects with other callbacks.
1ca5497 to
364460a
Compare
f39b6fa to
364460a
Compare
tylerjw
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RemoteControlclass currently spins the global queue when waiting for the user to confirm.It does so because the node handle for the subscriber that receives the feedback is usually initialized with the global callback queue. But that also means that other callbacks (including the one currently running!) can be processed in the thread that is waiting for user input and it's easy to block all available spinners or get into recursive spin calls for the same topic.
Even worse, there is no workaround: Even if the user provides a node handle with a different callback queue, the calls to
spinOncewill not even process that queue but the method calls still invoke unwanted side-effects without serving any purpose.Thus I modified the class to create its own spinner unconditionally.
@jspricke @tylerjw