Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix formatting CI job #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix formatting CI job #230

merged 1 commit into from
Jan 5, 2023

Conversation

vatanaksoytezer
Copy link
Collaborator

No description provided.

@auto-assign auto-assign bot requested a review from nbbrooks January 5, 2023 12:52
@vatanaksoytezer vatanaksoytezer requested review from henningkayser and tylerjw and removed request for nbbrooks January 5, 2023 12:52
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #230 (06870e7) into master (74b92d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   19.78%   19.78%           
=======================================
  Files           5        5           
  Lines        1703     1703           
=======================================
  Hits          337      337           
  Misses       1366     1366           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -11,7 +11,7 @@ on:
jobs:
pre-commit:
name: Format
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to go from 22.04 to 20.04 here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, this is the ros1 branch. Makes sense

@vatanaksoytezer vatanaksoytezer merged commit 1d83cb9 into master Jan 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the vatan/fix_format branch January 5, 2023 13:40
@vatanaksoytezer vatanaksoytezer restored the vatan/fix_format branch January 5, 2023 13:40
@vatanaksoytezer vatanaksoytezer deleted the vatan/fix_format branch January 5, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants