Customization of wave function for TileReflection
#1051
Conversation
This reverts commit c16778f.
|
This is cool, definitely has some interesting effects! I'm mostly unsure about the naming of the |
|
@cameronwhite what names would you suggest? |
|
I haven't thought much about names for the new modes, but for example you might label the existing mode as |
|
@cameronwhite, since we're focusing on the visual effect rather than the wave function, I’ve narrowed the options down to two to start (we can add more tile types later). I named the |
Pinta.Effects/Effects/TileEffect.cs
Outdated
| [Caption ("Intensity"), MinimumValue (-20), MaximumValue (20)] | ||
| public int Intensity { get; set; } = 8; | ||
|
|
||
| [Caption ("Wave Type")] |
There was a problem hiding this comment.
The caption here should also be updated to Tile Type
Pinta.Effects/Effects/TileEffect.cs
Outdated
|
|
||
| public enum TileType | ||
| { | ||
| [Caption ("Cleaved Edges")] |
There was a problem hiding this comment.
I'd maybe use Sharp rather than Cleaved here, since that might be easier to translate into other languages too
Pinta.Effects/Effects/TileEffect.cs
Outdated
| [Caption ("Cleaved Edges")] | ||
| CleavedEdges, | ||
|
|
||
| [Caption ("Curved Edges")] |
There was a problem hiding this comment.
How about just Curved or Round?
From what I recall when testing it out last week, in this mode it's more like the whole tile is curved, whereas the other mode is more like a flat tile except at the edges
|
@cameronwhite I implemented your suggestions 👍 |
The sharp, clear-cut edges of the tiles in
TileReflectionare achieved through the tangent function, which approaches infinite on one side and minus infinite on the other side, resulting in very sudden jumps.But what if we chose a different function? For example if we chose sine, the image would be bulged in a tile pattern but it wouldn't have clear edges. Other functions would behave in different, interesting ways.