-
Notifications
You must be signed in to change notification settings - Fork 332
Fixes #1390 #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1390 #1411
Conversation
cameronwhite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This does fix the issue when clicking on a palette color, but if you click on the primary or secondary color (at the far left of the status bar) a similar issue happens where the color is updated
if that seems more complicated to fix then I'm fine to merge these changes though!
|
|
||
| private void OnShrinkButtonClicked (Gtk.Button button, EventArgs args) | ||
| { | ||
| //var contentArea = this.GetContentAreaBox (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this commented code could just be removed now
Thanks @cameronwhite . It seems to work correctly on my PC. Do you have a screen capture where I can see what you describe? |
|
Sure, here is what I was doing: Screen.Recording.2025-05-05.at.7.55.43.PM.mp4 |
|
Thank you @cameronwhite . I was not fully aware that one could change palette colors like that, but now I see how to do it and it behaves as expected on my end. As for the primary and secondary colors, it's interesting that it behaves incorrectly on your machine, because it works on mine. I am testing Pinta on a virtual machine with Ubuntu Mate 24.04.1 LTS. What about you? It's worth asking, even though nothing here seems to me to be OS-specific (although I haven't looked in depth). |
|
I was testing on macOS - I can do a bit of debugging on my end to see what's happening |
|
I think the problem is that the I'll test and commit a fix - we should be able to remove that event handler when closing like we do for some other events |
This ensures that the palette colors aren't updated unexpectedly due to the event being triggered as the dialog is being closed
See second commit.
The issue was first mentioned in #1382 (comment)