Support a menubar layout #1418
Merged
Support a menubar layout #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing the non-headerbar layout on Linux (KDE), doing this in the 'activate' event caused the menubar to not appear - it seems necessary to do this during the startup event. This also seems to have fixed intermittent issues on macOS where the global menu was left empty. The header bar is still populated during the 'activate' event along with creating the rest of the window, so some refactoring was needed to enable this.
…bled. Otherwise, the Quit action isn't connected to anything and the application doesn't close.
This seems to be necessary to get the menubar to appear if a global menu isn't being used
To support this, the ToggleCommand.Toggled event now indicates whether it was interactively toggled, to avoid popping up a message when the action is "toggled" by loading the setting during startup
Contributor
|
Is there an easy way to remove this gray line under the menu? As there is already the shadow of the window decoration, it becomes a bit heavy with all those lines. |
Member
Author
|
I don't recall seeing an option for whether that shadow is displayed, but perhaps there is some CSS styling that can be modified |
cameronwhite
added a commit
that referenced
this pull request
May 30, 2025
* Initialize the application menubar during the 'startup' event When testing the non-headerbar layout on Linux (KDE), doing this in the 'activate' event caused the menubar to not appear - it seems necessary to do this during the startup event. This also seems to have fixed intermittent issues on macOS where the global menu was left empty. The header bar is still populated during the 'activate' event along with creating the rest of the window, so some refactoring was needed to enable this. * On macOS, populate the Application menu even if the header bar is enabled. Otherwise, the Quit action isn't connected to anything and the application doesn't close. * Enable the 'ShowMenubar' property for the Gtk.Application This seems to be necessary to get the menubar to appear if a global menu isn't being used * Add an option in the View menu to enable the menu bar * Notify the user to restart after changing the menubar option To support this, the ToggleCommand.Toggled event now indicates whether it was interactively toggled, to avoid popping up a message when the action is "toggled" by loading the setting during startup (cherry picked from commit 478ac3f)
cameronwhite
added a commit
that referenced
this pull request
Jun 8, 2025
* Initialize the application menubar during the 'startup' event When testing the non-headerbar layout on Linux (KDE), doing this in the 'activate' event caused the menubar to not appear - it seems necessary to do this during the startup event. This also seems to have fixed intermittent issues on macOS where the global menu was left empty. The header bar is still populated during the 'activate' event along with creating the rest of the window, so some refactoring was needed to enable this. * On macOS, populate the Application menu even if the header bar is enabled. Otherwise, the Quit action isn't connected to anything and the application doesn't close. * Enable the 'ShowMenubar' property for the Gtk.Application This seems to be necessary to get the menubar to appear if a global menu isn't being used * Add an option in the View menu to enable the menu bar * Notify the user to restart after changing the menubar option To support this, the ToggleCommand.Toggled event now indicates whether it was interactively toggled, to avoid popping up a message when the action is "toggled" by loading the setting during startup (cherry picked from commit 478ac3f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #781