Dithering effect can now use toolbar palette #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronwhite
reviewed
Jul 5, 2025
|
|
||
| public enum PaletteSource | ||
| { | ||
| [Caption ("Predefined Palettes")] |
Member
There was a problem hiding this comment.
Nitpicking on naming, how about Preset Palette to be consistent with Preset Gradient?
Something like Current Palette might also be a safer choice than Toolbar Palette in case there are any UI changes in the future where it's no longer in the bottom toolbar
Contributor
Author
There was a problem hiding this comment.
No problem, I just changed the names 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.