Ported 'dents' effect from old version of Paint.NET #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think I'm good to keep the tests there but disabled for now until the PintaCore dependency can be fixed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the code of the original effect:
https://github.com/rivy/OpenPDN/blob/cca476b0df2a2f70996e6b9486ec45327631568c/src/Effects/DentsEffect.cs
The icon is from that old version of Paint.NET, too:
https://github.com/rivy/OpenPDN/blob/cca476b0df2a2f70996e6b9486ec45327631568c/src/Resources/Icons/DentsEffectIcon.png
I also refactored the methods for Perlin noise calculations (used by
CloudsEffect, too) into their own class.Tests fail because
WarpEffectdepends onPintaCorebeing initialized, so I commented them out the tests. We could either:EffectsTest.csfile. It would still be fine because we have this PR as reference for when refactoring happens, and it would be less work to add the tests then.