Fix incorrect cutting/pasting behavior #951 #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinta.Core/Classes/DocumentLayers.cs
Outdated
| var g = new Context (surf); | ||
|
|
||
| // Use the EvenOdd fill rule to account for "holes" in the selection | ||
| g.FillRule = FillRule.EvenOdd; |
Member
There was a problem hiding this comment.
Thanks for looking into this!
The fix looks like the correct change, but even better would be to replace these three lines with document.Selection.Clip (g); which wraps up all of this logic
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! I changed it to use the Clip function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug described in #951 about incorrect cutting/pasting behavior.
Previously, the clipping operation would incorrectly include everything within the outer bounds of the selection, even when the selected area contained unselected regions.
This fix makes sure that inner regions are correctly handled as shown in the video.
2024-09-16_11.15.02.mp4