Sharepoint - update siteId prop #18361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughUpdates the SharePoint component: bumps package and several action/source versions; updates dependency on @pipedream/platform; adds a new listAllSites method and switches siteId async options to use it instead of listSites. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant W as Workflow UI
participant S as SharePoint App
participant G as Microsoft Graph API
U->>W: Open site selector (siteId)
W->>S: Fetch async options
note right of S: New behavior: use listAllSites()
S->>G: GET /sites?search=*
G-->>S: 200 OK • List of sites
S-->>W: Mapped options
W-->>U: Display sites
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks (3 passed, 2 warnings)❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Poem
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
components/sharepoint/sharepoint.app.mjs (2)
17-23: Switching siteId options to listAllSites fixes first-time user empty state.Good call replacing followed sites with a tenant-wide site search; this should resolve #18149 for new users with no followed sites.
Consider a label fallback to avoid blank option labels when displayName is missing:
- const options = response.value?.map(({ id: value, displayName: label }) => ({ value, label })) || []; + const options = response.value?.map(({ id: value, displayName, webUrl }) => ({ + value, + label: displayName || webUrl || value, + })) || [];
208-213: listAllSites implementation works; minor robustness/perf tweak suggested.Current path embedding
?search=*is fine. Optional: accept a search param and add $select to reduce payload.Apply:
- listAllSites(args = {}) { - return this._makeRequest({ - path: "/sites?search=*", - ...args, - }); - }, + listAllSites({ search = "*", params = {}, ...args } = {}) { + return this._makeRequest({ + path: "/sites", + params: { search, $select: "id,displayName,webUrl", ...params }, + ...args, + }); + },This keeps paging via
args.urlworking and trims response size.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
components/sharepoint/actions/create-item/create-item.mjs(1 hunks)components/sharepoint/actions/create-list/create-list.mjs(1 hunks)components/sharepoint/actions/download-file/download-file.mjs(1 hunks)components/sharepoint/actions/update-item/update-item.mjs(1 hunks)components/sharepoint/package.json(2 hunks)components/sharepoint/sharepoint.app.mjs(2 hunks)components/sharepoint/sources/new-list-item/new-list-item.mjs(1 hunks)components/sharepoint/sources/updated-list-item/updated-list-item.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (8)
components/sharepoint/sources/updated-list-item/updated-list-item.mjs (1)
8-8: Version bump looks good.No runtime changes. This source will automatically benefit from the new siteId options in the app.
components/sharepoint/actions/create-item/create-item.mjs (1)
7-7: Version bump acknowledged.No behavioral changes in this action.
components/sharepoint/actions/download-file/download-file.mjs (1)
8-8: Version bump acknowledged.No behavioral changes introduced here.
components/sharepoint/actions/update-item/update-item.mjs (1)
8-8: Version bump acknowledged.No behavioral changes in this action.
components/sharepoint/package.json (1)
3-3: Package + platform bump: verify axios + auth semantics for @pipedream/platform ^3.1.0
- platform/package.json is v3.1.0 and many components already target ^3.1.0.
- components/sharepoint has no axios(...) matches in the scan; still confirm any HTTP/auth code:
- uses import { axios } from "@pipedream/platform" (see packages/prompts/src/index.ts / components/browserless/browserless.app.mjs),
- does not assume response is in res.data (platform axios returns the response body directly unless config.returnFullResponse = true),
- and that any auth helpers/APIs used by the component are compatible with platform v3.1.0.
components/sharepoint/sources/new-list-item/new-list-item.mjs (1)
8-8: Version bump looks good.No logic changes. This source will pick up the new siteId options from the app.
components/sharepoint/actions/create-list/create-list.mjs (1)
7-7: Version bump acknowledged.No behavioral changes in this action.
components/sharepoint/sharepoint.app.mjs (1)
12-30: Confirm Graph scopes allow listing SharePoint sitesListing /sites?search=* can require Sites.Read.All (delegated or application) with admin consent — verify the app registration's OAuth scopes/consent. Repo grep returned no hits for "Sites.Read" or "scope"; manual verification required: open the SharePoint action, expand the Site selector, and confirm sites load with pagination on a fresh account.
jcortes
approved these changes
Sep 12, 2025
sergio-eliot-rodriguez
pushed a commit
to sergio-eliot-rodriguez/sergio_wong_does_pipedream
that referenced
this pull request
Sep 21, 2025
* update siteId prop * pnpm-lock.yaml * package.json version
vunguyenhung
added a commit
that referenced
this pull request
Sep 24, 2025
* Leonardo AI components * added unzoom image action * fixing link errors * more lint fixes * Merging pull request #18359 * fix: pagination prop and params struct * fix: no need for paginate here * chore: update version * chore: cleanup * chore: update package * feat: allow raw response * chore: bump package * fix: buffer response instead * Update components/google_drive/actions/download-file/download-file.mjs Co-authored-by: Jorge Cortes <[email protected]> * versions * pnpm-lock.yaml * pnpm-lock.yaml * pnpm-lock.yaml * feat: add content selector * chore: bump package * fix: comments * chore: bump versions * chore: fix versions * fixes: QA fixes * feat: add cursor to req * package.json --------- Co-authored-by: joao <[email protected]> Co-authored-by: joaocoform <[email protected]> Co-authored-by: Jorge Cortes <[email protected]> Co-authored-by: Michelle Bergeron <[email protected]> Co-authored-by: Luan Cazarine <[email protected]> * Merging pull request #18361 * update siteId prop * pnpm-lock.yaml * package.json version * Google Sheets - update row refresh fields (#18369) * change prop order and refresh fields * bump package.json * Pipedrive - fix app name (#18370) * use pipedriveApp instead of app * bump package.json * Pipedrive - pipelineId integer (#18372) * pipelineId - integer * bump versions * Adding app scaffolding for lightspeed_ecom_c_series * Adding app scaffolding for financial_data * Adding app scaffolding for microsoft_authenticator * Merging pull request #18345 * updates * versions * versions * Merging pull request #18368 * updates * remove console.log * versions * Coinbase Developer Platform - New Wallet Event (#18342) * new component * pnpm-lock.yaml * updates * updates * Hubspot - update search-crm (#18360) * update search-crm * limit results to one page * update version * package.json version * Merging pull request #18347 * widget props * fix version * Adding app scaffolding for rundeck * Merging pull request #18378 * Update Taiga component with new actions and sources - Bump version to 0.1.0 in package.json and add dependency on @pipedream/platform. - Introduce new actions for creating, updating, and deleting issues, tasks, and user stories. - Add sources for tracking changes and deletions of issues and tasks. - Implement utility functions for parsing and cleaning objects in common/utils.mjs. - Enhance prop definitions for better integration with Taiga API. * pnpm update * Refactor Taiga actions to utilize parseObject utility - Added parseObject utility for tags, watchers, and points in update-issue, update-task, and update-userstory actions. - Removed the update-project action as it is no longer needed. - Enhanced base source to include secret key validation for webhook security. * Merging pull request #18382 * add testSources prop * pnpm-lock.yaml * fix * Merging pull request #18323 * Added actions * Added actions * Added actions * Merging pull request #18377 * Added actions * Update components/weaviate/actions/create-class/create-class.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Luan Cazarine <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Merging pull request #18376 * Adding app scaffolding for etrusted * Adding app scaffolding for intelliflo_office * Adding app scaffolding for thoughtspot * Adding app scaffolding for kordiam * Adding app scaffolding for ticketsauce * trustpilot fixes (#18152) * trustpilot fixes * more fixes * update versions * more version updates * fixes * Bump all Trustpilot actions to version 0.1.0 Major improvements and API updates across all actions: - Enhanced private API support with proper authentication - Improved parameter handling and validation - Better error handling and response structures - Added new conversation flow for product reviews - Fixed endpoint URLs to match latest API documentation - Streamlined request/response processing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * up version and clean up sources * merge * fix business ID * delete temp action * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-product-reviews/new-product-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update components/trustpilot/sources/new-service-reviews/new-service-reviews.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * comments * Pagination * fixes * comments * missed some `$`'s * unduplicated * more fixes * final comments * more comments * . --------- Co-authored-by: Claude <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Adding app scaffolding for peekalink * 18314 twilio (#18350) * Update Twilio component versions and dependencies - Update Twilio Send Message action adding detailed description for 'from' prop and refactoring phone number validation logic. - Incremented action versions for several Twilio actions. * pnpm update * Updating LinkedIn API version (#18399) * Merging pull request #18394 * Databricks API - Jobs action components (#18371) * Notion property building improvements (#18381) * validate property types * versions * Google Business - add debug log (#18407) * add debug log * bump versions * Notion API Key - update @pipedream/notion version (#18409) * update @pipedream/notion dependency version * pnpm-lock.yaml * Adding app scaffolding for reduct_video * Adding app scaffolding for shopware * Adding app scaffolding for instamojo * Hubspot - bug fix to sources w/ property changes (#18379) * updates * versions * Google sheets type fix (#18411) * Fixing worksheetId prop type from string to integer * Version bumps --------- Co-authored-by: Leo Vu <[email protected]> * Merging pull request #18393 * new components * remove console.log * versions * update * Merging pull request #18408 * 403 error message * versions * update * Merging pull request #18419 * Changes per PR Review * Removes leonardo_ai_actions.mdc not indented for merging * synced lockfile after install * fully lock form-data for leonardo_ai * conflict solving * lint fixes * Chipped down Readme, implemented async options in gen motion --------- Co-authored-by: jocarino <[email protected]> Co-authored-by: joao <[email protected]> Co-authored-by: joaocoform <[email protected]> Co-authored-by: Jorge Cortes <[email protected]> Co-authored-by: Michelle Bergeron <[email protected]> Co-authored-by: Luan Cazarine <[email protected]> Co-authored-by: michelle0927 <[email protected]> Co-authored-by: Andrew Chuang <[email protected]> Co-authored-by: danhsiung <[email protected]> Co-authored-by: Lucas Caresia <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Job <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Guilherme Falcão <[email protected]> Co-authored-by: Leo Vu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18149
Summary by CodeRabbit