Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

andrewjschuang
Copy link
Collaborator

@andrewjschuang andrewjschuang commented Mar 14, 2023

Updates all axios imports to @pipedream/platform.

For the reviewer:
Please take a attentive look at this PR.
When approved, I don't think this needs QA and will be merged directly.

Notes:

  • Even though there is space for refactoring apps and components' methods (i.e. creating a common _makeRequest method), in this PR I opted to make minimal changes so there is minimal impact.
  • The newly published 1.4.0 version of @pipedream/platform supports a flag named returnFullResponse, when true, returns the same object as the regular axios after making a request. This enables us to use the pipedream package when needing the response headers, for example. The default value is false; it returns just data like we are used to.

Resolves #5674.

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
pipedream-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 4:40PM (UTC)
pipedream-docs-redirect-do-not-edit ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 4:40PM (UTC)

@andrewjschuang
Copy link
Collaborator Author

andrewjschuang commented Mar 14, 2023

  • Unpublish the following components:

close:

  • close-custom-source

zoom_admin:

  • zoom_admin-action-add-meeting-registrant
  • zoom_admin-action-add-webinar-panelist
  • zoom_admin-action-add-webinar-registrant
  • zoom_admin-action-create-a-meeting
  • zoom_admin-action-create-a-webinar
  • zoom_admin-action-delete-cloud-recording
  • zoom_admin-action-delete-meeting
  • zoom_admin-action-remove-webinar-panelist
  • zoom_admin-action-delete-webinar
  • zoom_admin-action-end-meeting
  • zoom_admin-action-get-meeting
  • zoom_admin-action-get-webinar
  • zoom_admin-action-list-cloud-recordings
  • zoom_admin-action-list-meeting-registrants
  • zoom_admin-action-list-meetings
  • zoom_admin-action-list-webinar-registrants
  • zoom_admin-action-list-webinars
  • zoom_admin-action-update-a-meeting
  • zoom_admin-action-update-webinar-registrant-status
  • zoom_admin-action-update-a-webinar

Copy link
Collaborator

@luancazarine luancazarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewjschuang, Thanks for your contribution! LGTM!

@andrewjschuang andrewjschuang merged commit 6e1c895 into master Mar 14, 2023
@andrewjschuang andrewjschuang deleted the refactor-axios-imports branch March 14, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Update all axios imports to use @pipedream/platform
2 participants