Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Introduced protections against "zip slip" attacks #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduced protections against "zip slip" attacks #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rewrite-core/src/main/java/org/openrewrite/remote/RemoteArchive.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package org.openrewrite.remote;

import io.github.pixee.security.ZipSecurity;
import lombok.EqualsAndHashCode;
import lombok.Value;
import lombok.With;
Expand Down Expand Up @@ -112,7 +113,7 @@ public InputStream getInputStream(ExecutionContext ctx) {
}

private @Nullable InputStream readIntoArchive(InputStream body, List<String> paths, int index) {
ZipInputStream zis = new ZipInputStream(body);
ZipInputStream zis = ZipSecurity.createHardenedInputStream(body);
Pattern pattern = Pattern.compile(paths.get(index));

try {
Expand Down
3 changes: 2 additions & 1 deletion rewrite-java-test/src/test/resources/dataflow-functional-tests/JobUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
*/
package com.intuit.karate.job;

import io.github.pixee.security.ZipSecurity;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
Expand Down Expand Up @@ -87,7 +88,7 @@ private static void zip(File fileToZip, String fileName, ZipOutputStream zipOut,
public static void unzip(File src, File dest) {
try {
byte[] buffer = new byte[1024];
ZipInputStream zis = new ZipInputStream(new FileInputStream(src));
ZipInputStream zis = ZipSecurity.createHardenedInputStream(new FileInputStream(src));
ZipEntry zipEntry = zis.getNextEntry();
while (zipEntry != null) {
File newFile = createFile(dest, zipEntry);
Expand Down
Loading