feat(cli): add explicit --descending sort flag#48
Open
jasonandjay wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| .maybe_offset(offset) | ||
| .maybe_order(order) | ||
| .ascending(ascending) | ||
| .ascending(if descending { false } else { ascending }) |
There was a problem hiding this comment.
Redundant conditional — descending variable has no effect
Low Severity
The expression if descending { false } else { ascending } is equivalent to just ascending in all valid input states, because the conflicts_with constraint guarantees descending and ascending can never both be true. When descending is true, ascending is already false, so the explicit false branch is redundant. The descending variable appears to influence behavior but never does, which is misleading. This pattern is repeated across all six call sites.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #17
Summary
--descendingflag as counterpart to existing--ascending.conflicts_with.Notes
Note
Low Risk
Low risk CLI-only change: adds a new
--descendingflag and makes sort-direction flags mutually exclusive without changing default behavior.Overview
Adds an explicit
--descendingCLI flag (mutually exclusive with--ascending) across list-style commands (markets,events,series,sports teams,tags, andcomments).Updates request construction so
--descendingforcesascending=falsewhile preserving the existing default of descending sort when neither flag is provided.Written by Cursor Bugbot for commit 63fa9a1. This will update automatically on new commits. Configure here.