Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make module formatting not generate error with strict mode#11943

Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom
jazzdelightsme:user/danthom/strictModuleInfoFix
May 27, 2020
Merged

Make module formatting not generate error with strict mode#11943
TravisEz13 merged 2 commits intoPowerShell:masterfrom
jazzdelightsme:user/danthom/strictModuleInfoFix

Conversation

@jazzdelightsme
Copy link
Contributor

Fixes #11909

PR Summary

Minor tweak to module formatting script to avoid errors when strict mode is on.

PR Checklist

@ghost ghost assigned TravisEz13 Feb 24, 2020
@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Feb 26, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 27, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 28, 2020
@daxian-dbw daxian-dbw mentioned this pull request Mar 13, 2020
14 tasks
@jazzdelightsme
Copy link
Contributor Author

@SteveL-MSFT Quickest way to get me using a pre-release build would be to ship this change in one. ;)

@TravisEz13
Copy link
Member

@SteveL-MSFT Can you update your review?

@ghost ghost added the Review - Needed The PR is being reviewed label May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

@TravisEz13
Copy link
Member

pinged @SteveL-MSFT offline to update his review

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@TravisEz13 TravisEz13 removed the Review - Needed The PR is being reviewed label May 27, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.4 milestone May 27, 2020
@TravisEz13 TravisEz13 merged commit 0137920 into PowerShell:master May 27, 2020
@jazzdelightsme jazzdelightsme deleted the user/danthom/strictModuleInfoFix branch May 27, 2020 22:55
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get-Module is polluting $error (from formatting script) (when strict mode on)

4 participants